Application::run returns on native platforms #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hecrj
requested changes
Nov 8, 2021
|
yeah - I somehow overlooked that. I did not want to change the control flow of I realized that the run() method may return normally when running through the code for the pull-request. Letting it return in all cases would be simpler than any callback - unless returning from |
|
Removed the on_exit() callback entirely and added an example that Added another commit that demonstrates the same when calling |
hecrj
requested changes
Nov 21, 2021
|
sure, I get rid of the examples... and rename the pull request. There is no more on_exit callback |
AndiHofi
changed the title
hecrj
force-pushed
the
on_exit_callback
branch
from
772ed0f to
2f50d11
Compare
hecrj
approved these changes
Nov 29, 2021
This was referenced Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an
on_exit() -> Option<Box<dyn FnOnce>>function to the iced::Application trait that provides that callback.When the returned closure does not actually exit the application then
iced::Application::run()can return as well, allowing the program to continue when the main window is closed.For iced_web it could make sense to invoke the on_exit() closure when unloading the page, did not try to implement that though.
The main use-case for this is to allow to change the exit code of the application.